[JENKINS-64553] fix ItemListener not called after updating job via REST API or CLI #9304

mawinter69 · 2024-05-24T07:27:49Z

when a job is updated via REST API or CLI, the
ItemListener.fireOnUpdated is now called to inform about the change.

See JENKINS-64553.

Testing done

added a Unit test that verifies ItemListener is called. Without the change the test fails.

Proposed changelog entries

Consistently notify job listeners when the job definition is updated from the REST API or command line interface.

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

when a job is updated via REST API or CLI, the ItemListener.fireOnUpdated is now called to inform about the change.

MarkEWaite · 2024-05-25T21:51:39Z

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

mawinter69 · 2024-05-26T10:44:31Z

@krisstern This might be a candidate for the next LTS 2.452.2

krisstern · 2024-05-26T10:46:37Z

Hi @mawinter69,
Sure, let me add this to the backporting of LTS 2.452.2 soon.

…ST API or CLI (jenkinsci#9304) [JENKINS-64553] call ItemListener after updating job via cli when a job is updated via REST API or CLI, the ItemListener.fireOnUpdated is now called to inform about the change. (cherry picked from commit dae1737)

jglick · 2024-08-07T16:07:34Z

Note: this does not suffice for onUpdated to be called from other code that happens to save a Job (e.g., adding/removing JobPropertys). Perhaps the existing fireOnUpdated call sites should be deleted and replaced with one call from

jenkins/core/src/main/java/hudson/model/AbstractItem.java

Line 617 in 9b1b1c6

SaveableListener.fireOnChange(this, getConfigFile());

regardless of the save’s origin.

[JENKINS-64553] call ItemListener after updating job via cli

bb84dea

when a job is updated via REST API or CLI, the ItemListener.fireOnUpdated is now called to inform about the change.

MarkEWaite added the bug For changelog: Minor bug. Will be listed after features label May 25, 2024

MarkEWaite approved these changes May 25, 2024

View reviewed changes

NotMyFault approved these changes May 25, 2024

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 25, 2024

MarkEWaite merged commit dae1737 into jenkinsci:master May 27, 2024
16 checks passed

tomasbjerre mentioned this pull request Jun 20, 2024

Pipelines inside a Multibranch Pipeline not being found jenkinsci/generic-webhook-trigger-plugin#314

Closed

jglick mentioned this pull request Sep 17, 2024

Introduce SaveableListener#onDeleted #9743

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-64553] fix ItemListener not called after updating job via REST API or CLI #9304

[JENKINS-64553] fix ItemListener not called after updating job via REST API or CLI #9304

mawinter69 commented May 24, 2024 •

edited by MarkEWaite

Loading

Submitter checklist

Maintainer checklist

MarkEWaite commented May 25, 2024

mawinter69 commented May 26, 2024

krisstern commented May 26, 2024

jglick commented Aug 7, 2024

[JENKINS-64553] fix ItemListener not called after updating job via REST API or CLI #9304

[JENKINS-64553] fix ItemListener not called after updating job via REST API or CLI #9304

Conversation

mawinter69 commented May 24, 2024 • edited by MarkEWaite Loading

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Maintainer checklist

MarkEWaite commented May 25, 2024

mawinter69 commented May 26, 2024

krisstern commented May 26, 2024

jglick commented Aug 7, 2024

mawinter69 commented May 24, 2024 •

edited by MarkEWaite

Loading